-
Notifications
You must be signed in to change notification settings - Fork 176
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Abbreviate printing of AFunction and MultiFn objects
Instead of printing as #object[clojure.core$_PLUS_ 0x4e648e99 "clojure.core$_PLUS_@4e648e99"] they are now printed as #function[clojure.core/+] Instead of printing as #object[clojure.lang.MultiFn 0x4e648e99 "clojure.lang.MultiFn@0x4e648e99"] they are now printed as #multifn[print-method 0x3f0cd5b4] Disable this with (alter-var-root #'cider.nrepl.print-method/*pretty-objects* not)
- Loading branch information
Showing
4 changed files
with
88 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
(ns cider.nrepl.print-method | ||
(:require [clojure.string :as s]) | ||
(:import [clojure.lang AFunction MultiFn] | ||
java.io.Writer)) | ||
|
||
;; Extending `print-method` defined in clojure.core, to provide | ||
;; prettier versions of some objects. This applies to anything that | ||
;; calls `print-method`, which includes return values, `pr`, `print` | ||
;; and the likes. | ||
|
||
(def ^:dynamic *pretty-objects* | ||
"If true, cider prettifies some object descriptions. | ||
For instance, instead of printing functions as | ||
#object[clojure.core$_PLUS_ 0x4e648e99 \"clojure.core$_PLUS_@4e648e99\"] | ||
they are printed as | ||
#function[clojure.core/+] | ||
To disable this feature, do | ||
(alter-var-root #'cider.nrepl.print-method/*pretty-objects* not)" | ||
true) | ||
|
||
(defmacro def-print-method [dispatch-val arg & strings] | ||
`(defmethod print-method ~dispatch-val [~arg ~'^Writer w] | ||
(if *pretty-objects* | ||
(do ~@(map #(list '.write 'w %) strings)) | ||
(#'clojure.core/print-object ~arg ~'w)))) | ||
|
||
;;; Function objects | ||
;; Ex: #function[cider.nrepl.print-method/multifn-name] | ||
(def-print-method AFunction c | ||
"#function[" | ||
(-> (.getName (class c)) | ||
(s/replace-first "$" "/") | ||
(s/replace "_QMARK_" "?") | ||
(s/replace "_PLUS_" "+") | ||
(s/replace "_BANG_" "!") | ||
(s/replace "_EQ_" "=") | ||
(s/replace "_SLASH_" "/") | ||
(s/replace "_STAR_" "*") | ||
(s/replace "_" "-")) | ||
"]") | ||
|
||
;;; Multimethods | ||
;; Ex: #multifn[print-method 0x3f0cd5b4] | ||
(defn multifn-name [^MultiFn mfn] | ||
(let [field (.getDeclaredField MultiFn "name") | ||
private (not (.isAccessible field))] | ||
(when private | ||
(.setAccessible field true)) | ||
(let [name (.get field mfn)] | ||
(when private | ||
(.setAccessible field false)) | ||
name))) | ||
|
||
(def-print-method MultiFn c | ||
"#multifn[" | ||
(try (multifn-name c) | ||
(catch SecurityException _ | ||
(class c))) | ||
;; MultiFn names are not unique so we keep the identity HashCode to | ||
;; make sure it's unique. | ||
(format " 0x%x]" (System/identityHashCode c))) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
(ns cider.nrepl.print-method-test | ||
(:require [cider.nrepl.print-method :refer :all] | ||
[clojure.test :refer :all]) | ||
(:import java.util.regex.Pattern)) | ||
|
||
(defn dummy-fn [o]) | ||
|
||
(deftest print-functions | ||
(are [f s] (= (pr-str f) s) | ||
print-functions "#function[cider.nrepl.print-method-test/print-functions]" | ||
dummy-fn "#function[cider.nrepl.print-method-test/dummy-fn]" | ||
multifn-name "#function[cider.nrepl.print-method/multifn-name]" | ||
+ "#function[clojure.core/+]" | ||
* "#function[clojure.core/*]" | ||
/ "#function[clojure.core//]" | ||
map? "#function[clojure.core/map?--4138]")) | ||
|
||
(deftest print-multimethods | ||
(require 'cider.nrepl.middleware.track-state) | ||
(doseq [it '(print-method cider.nrepl.middleware.track-state/ns-as-map)] | ||
(let [var (resolve it)] | ||
(is (re-find (Pattern/compile (format "#multifn\\[%s 0x[a-z0-9]+\\]" | ||
(:name (meta var)))) | ||
(pr-str @var)))))) |