Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root-cause to exceptions in err-info #225

Closed
Malabarba opened this issue Jul 2, 2015 · 8 comments
Closed

Add root-cause to exceptions in err-info #225

Malabarba opened this issue Jul 2, 2015 · 8 comments

Comments

@Malabarba
Copy link
Member

As mentioned here. Do something like this.

@bbatsov
Copy link
Member

bbatsov commented Jul 15, 2015

Indeed. Let's hope we'll manage to squeeze this in 0.10.

@bbatsov
Copy link
Member

bbatsov commented Dec 15, 2015

You'll have to remind us what we were supposed to do here, as your fork no longer exists.

@Malabarba
Copy link
Member Author

No idea. Guess we can close this for now. :-)

@bbatsov
Copy link
Member

bbatsov commented Dec 15, 2015

My guess is that err-info is discarding the root cause or something like this.

@cichli
Copy link
Member

cichli commented Dec 18, 2015

Possibly you're referring to the root-ex slot that regular nREPL eval returns? https://github.com/clojure/tools.nrepl/blob/master/src/main/clojure/clojure/tools/nrepl/middleware/interruptible_eval.clj#L122-L124

Because we use clojure.stacktrace/print-cause-trace, this information is (indirectly) included in the response, if you examine the cause trace. But I do think it would be nice to unify the interface of eval errors and our middleware errors.

@bbatsov
Copy link
Member

bbatsov commented Dec 18, 2015

Ah, yes. I'm pretty sure this is what I meant.

@bbatsov
Copy link
Member

bbatsov commented Apr 9, 2016

@sanjayl Maybe you'd like to tackle this task as well?

@mallt
Copy link
Contributor

mallt commented Nov 4, 2018

Would it suffice for this issue to simply add a :root-ex key to the error summary that holds the classname of the root cause?

mallt added a commit to mallt/cider-nrepl that referenced this issue Nov 7, 2018
@bbatsov bbatsov closed this as completed in fa43d28 Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants