Apropos creates useless regex when not passed a search

[SevereOverfl0w]

cider-nrepl/src/cider/nrepl/middleware/apropos.clj

Lines 21 to 22 in d18a6e8

	(not (:case-sensitive? msg))
	(update-in [:var-query :search] #(format "(?i:%s)" %))

If there is no search this will generate (?i:null) which doesn't match much. It should do a when around the search first.

[bbatsov]

But isn't search mandatory? What exactly is apropos going to do without it?

[SevereOverfl0w]

It's fully capable of working without it now, the var-query will return everything if no search is provided (excluding other filters such as metadata and test). For example, you should be able to use apropos to filter for all tests by using:

{:op "apropos" :var-query {"test?" 1}}

Not providing search is the same as having search set to #".*", but without the effort of actually running regex.

[MalloZup]

autogenerated with https://github.com/MalloZup/doghub: issue inactive since 450 days. Please update the issue or close it

[bbatsov]

Fixed by #666. The PR of the Beast! 😆