Should ns-vars-with-meta-clj return public vars?

[liquidz]

Question

• ns-vars-with-meta-clj uses ns-interns and returns all vars including private vars
  • Should ns-vars-with-meta-clj use ns-publics ?

Actual behavior

• ns-vars-clj uses ns-publics

  • cider-nrepl/src/cider/nrepl/middleware/ns.clj

    Line 20 in b13881e

    (defn ns-vars-clj [ns]

• ns-vars-cljs uses cljs-analysis/public-vars

  • cider-nrepl/src/cider/nrepl/middleware/ns.clj

    Line 40 in b13881e

    (defn ns-vars-cljs [env ns]

• ns-vars-with-meta-cljs uses cljs-analysis/public-var

  • cider-nrepl/src/cider/nrepl/middleware/ns.clj

    Line 47 in b13881e

    (defn ns-vars-with-meta-cljs [env ns]

• but ns-vars-with-meta-clj uses ns-interns

  • cider-nrepl/src/cider/nrepl/middleware/ns.clj

    Line 27 in b13881e

    (defn ns-vars-with-meta-clj [ns]

Environment & Version information

cider-nrepl version

0.18.0

[bbatsov]

@liquidz Nice catch!

I think that was probably just an oversight and we should be consistent everywhere (meaning return public vars only).

I guess potentially we can extend this API by making it possible to request all vars, including the private ones. Does this make sense?

[liquidz]

I guess potentially we can extend this API by making it possible to request all vars, including the private ones. Does this make sense?

@bbatsov Yes, I think too.
I'll fix codes!