-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix *print-right-margin* binding in wrap-pprint-fn
#436
Conversation
A side question. Does anyone know how to reset nrepl handler? For some wrappers like |
@@ -66,7 +66,7 @@ | |||
(binding [*print-length* (or print-length (get @session #'*print-length*)) | |||
*print-level* (or print-level (get @session #'*print-level*)) | |||
*print-meta* (or print-meta (get @session #'*print-meta*)) | |||
*print-right-margin* (or print-right-margin (get @session #'*print-right-margin*))] | |||
*print-right-margin* (or print-right-margin *print-right-margin*)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a remark here explaining the difference.
Is this an nREPL bug then? |
No, session is binding only a few essential things and current thread bindings returned by Alternatively, bindings could be added when nrepl session is created but I don't think this should be the case here. |
Ah, I totally forgot about this.
I think your current fix is all that's needed. |
None of the functionality currently relying on
wrap-pprint-fn
is pretty printing. The reason is that*print-right-margin*
is always set to nil as@session
is not binding it.To reproduce
and you should see ex-info data printed in one long line within the stack trace.