Integrate the new suitable ClojureScript completion #641
Conversation
arichiardi
force-pushed
the
integrate-cljs-completions
branch
3 times, most recently
from
bbb01f9 to
f81ffd6
Compare
arichiardi
changed the title
arichiardi
changed the title
arichiardi
force-pushed
the
integrate-cljs-completions
branch
from
f81ffd6 to
809df44
Compare
arichiardi
changed the title
|
Found a couple of problems, working on patches. |
arichiardi
force-pushed
the
integrate-cljs-completions
branch
2 times, most recently
from
0ffff4c to
98a6d61
Compare
|
Roger that! FYI - I plan to cut a new release in about a week (for the IN/Clojure conference). |
arichiardi
force-pushed
the
integrate-cljs-completions
branch
6 times, most recently
from
d80ef34 to
be1cd01
Compare
| :compliment.sources.namespaces-and-classes/namespaces-and-classes | ||
| :compliment.sources.special-forms/special-forms]) | ||
|
|
||
| (def +cljs-sources+ |
There was a problem hiding this comment.
it is a (questionable 😄) convention I got from boot for globals that are not ^:dynamic. I can get rid of it if we don't like it.
There was a problem hiding this comment.
Seems weird to me, plus it's not consistent with the rest of our code. Let's remove them.
| :extra-metadata extra-metadata})))) | ||
| (binding [suitable-sources/*compiler-env* cljs-env] | ||
| (concat (complete/completions prefix (merge completion-opts {:sources +cljs-sources+})) | ||
| (when enhanced-cljs-completion? (suitable/complete-for-nrepl msg)))) |
There was a problem hiding this comment.
Shouldn't this just add one more compliment source?
There was a problem hiding this comment.
As far I understand, the enhanced completions are not a defsource at the moment, maybe @rksm can expand on that
There was a problem hiding this comment.
Okay, let's hear what he'll tell us about those. It just seems super strange to me to have one set of completions as compliment source and the others as something else.
|
You'll also have to to rebase and update the changelog. |
arichiardi
force-pushed
the
integrate-cljs-completions
branch
4 times, most recently
from
9769c93 to
4c6c131
Compare
This patch adds the necessary setup for ClojureScript completions with clj-suitable. It also inlines the call to cljs-complete so that we avoid having a wrapper.
| :dependencies [[nrepl "0.6.0"] | ||
| ^:inline-dep [cider/orchard "0.5.5"] | ||
| ^:inline-dep [thunknyc/profile "0.5.2"] | ||
| ^:inline-dep [mvxcvi/puget "1.2.0"] | ||
| ^:inline-dep [fipp "0.6.22"] ; can be removed in unresolved-tree mode | ||
| ^:inline-dep [compliment "0.3.10"] | ||
| ^:inline-dep [cljs-tooling "0.3.1"] |
|
I'll merge this as it is. We can fix the missing compliment source situation later. |
This patch adds the new feature to
cider-nrepland also deprecatescljs-tooling.It depends on the new version of
clj-suitableandcompliment.Before submitting a PR make sure the following things have been done:
Note: If you're just starting out to hack on
cider-nreplyou might findnREPL's documentation and the
"Design" section of the README extremely useful.*
Thanks!