-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change representation of debug-commands to a set of command names #654
Conversation
src/cider/nrepl/middleware/debug.clj
Outdated
"t" :trace}) | ||
"An unsorted set of commands supported by the debugger." | ||
#{:continue | ||
:Continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a proper name here - the current one was just to convey the relationship with C
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:continue-all
and :inspect-prompt
? Or maybe :inspect-current
for p
Would that also call for a command name -> display name mapping on the client side? Right now it's just using the plain command names as overlay titles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You read my mind. I was just writing about some display name mapping on the other ticket. :-)
:continue-all
👍
For inspect - let's have the default command inspect the current value and the other to be inspect-prompt
.
src/cider/nrepl/middleware/debug.clj
Outdated
:next | ||
:out | ||
:inspect | ||
:insPect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Btw, I guess the second inspect should go in a different PR, as we don't really have that command available currently. |
f59449d
to
11a9bf3
Compare
This is a breaking change that sends debug commands to the client as an unsorted list of command names without key mapping information, as a means of separating concerns.
11a9bf3
to
28594fc
Compare
Ok, I rebased the conflicts, removed the references to :insPect and renamed :Continue to :continue-all. Somehow I can't seem to get the test suite working locally -
|
@yuhan0 I see the debug integration test is failing currently on the CI. Seems like a real failure to me. |
Ok it was a fairly simple change, now all existing tests are passing :) |
@yuhan0 Just squash the last two commits and we're good to go. |
Update :Continue -> :continue-all in debug-integration-test
7a84ecb
to
9c01514
Compare
Great work! Thanks for tackling this! 🙇 |
Note: This is a breaking change that sends debug commands to the client as an unsorted
list of command names without key mapping information, as a means of separating
concerns.
Quick draft of the changes suggested in clojure-emacs/cider#2731
If everything looks alright I'll go ahead with adding changelog notes and tests
Before submitting a PR make sure the following things have been done: