Fix instrument for a dot special form case #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cartmanishere
force-pushed
the
dot-fix
branch
2 times, most recently
from
d10b4d2
to
cc8d530
Compare
bbatsov
reviewed
Mar 10, 2020
| @@ -73,7 +73,12 @@ | |||
| '#{new} (cons (first args) (instrument-coll (rest args))) | |||
| '#{quote & var clojure.core/import*} args | |||
| '#{.} (list* (first args) | |||
| (second args) | |||
| (let [s (second args)] | |||
There was a problem hiding this comment.
Might be a good idea to add some comments explaining this block of code.
bbatsov
reviewed
Mar 10, 2020
| @@ -138,6 +138,14 @@ | |||
| '#{[(def foo "foo doc" (bp (bar) {:coor [3]} (bar))) []] | |||
| [(bar) [3]]}))) | |||
|
|
|||
| (deftest instrument-dot-test | |||
| (is (= (t/breakpoint-tester '(. clojure.lang.Numbers add 1 x)) | |||
There was a problem hiding this comment.
Might be a good idea to wrap the tests in testing blocks with some explanations of why those cases are different.
|
Thanks for tackling this! I've left a couple of tiny remarks, but overall your changes look great! |
|
Added some comments in code and tests. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done:
Fix for #671
Instrumentation for dot special forms of type
(. clojure.lang.Numers (add 1 x))fails. There is no breakpoint set forx.This PR fixes this so that the breakpoints are set inside the dot special form.