[Inspector] Configure truncation limits #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Orchard 0.7 is out. You can update his PR. |
pdbrown
force-pushed
the
feature/inspect-display-length
branch
2 times, most recently
from
e6eccef to
6790663
Compare
pdbrown
force-pushed
the
feature/inspect-display-length
branch
from
6790663 to
ea7d1f2
Compare
bbatsov
reviewed
Apr 13, 2021
|
Migth be good idea to rebase on top of |
The limits after which the inspector truncates collection members are now configurable. Previously they were hardcoded to 5 and 150 for collection and atom (non-collection) members.
pdbrown
force-pushed
the
feature/inspect-display-length
branch
from
ea7d1f2 to
63e290e
Compare
pdbrown
commented
Apr 13, 2021
| ;; code isn't processed by mranderson and so can't refer to inlined deps | ||
| ;; including orchard. | ||
| ;; See also https://github.com/benedekfazekas/mranderson/issues/5 | ||
| (let [max-len 150 #_(var-get #'orchard.inspect/*max-atom-length*) |
There was a problem hiding this comment.
One other new change is an attempt to avoid hard-coding orchard's defaults here, but I couldn't get mranderson to munge the test code requires. I gave up after a few stabs at editing project.clj with-profile +test/:source-paths/:test-paths entries, and reverted to hard-coding. I think benedekfazekas/mranderson#5 is related.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: adjust cider/orchard version when published
The limits after which the inspector truncates collection members are now
configurable. Previously they were hardcoded to 5 and 150 for collection and
atom (non-collection) members.
This continues the work in clojure-emacs/orchard#111 and needs to be updated with the right orchard version number before it can merge.