Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undef-all op #698

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Add undef-all op #698

merged 4 commits into from
Apr 23, 2021

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Apr 23, 2021

The purpose of this op is to support a complete "reload" of a file or ns form in Cider (C-u M-x cider-load-file) and other clients.
Which is sometimes necessary when you have conflicting aliases or old/renamed vars sticking around in the REPL state.


Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

Note: If you're just starting out to hack on cider-nrepl you might find
nREPL's documentation and the
"Design" section of the README extremely useful.*

Thanks!

@bbatsov
Copy link
Member

bbatsov commented Apr 23, 2021

Looks like a good change to me. Don't forget to run lein docs to also regen the op docs.

@bbatsov bbatsov merged commit c91d065 into clojure-emacs:master Apr 23, 2021
@bbatsov
Copy link
Member

bbatsov commented Apr 23, 2021

Thanks! I'll push a new snapshot right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants