[inspector] Use orchard.inspect/refresh instead of individual setters #877
Conversation
src/cider/nrepl.clj
Outdated
| @@ -335,7 +335,7 @@ if applicable, and re-render the updated value." | |||
| :requires {"session" "The current session"} | |||
| :returns inspector-returns} | |||
| "inspect-refresh" | |||
| {:doc "Re-renders the currently inspected value." | |||
| {:doc "Updates inspector with the provided config and re-renders the current value. Supports the same config keys as {\"op\" \"eval\", \"inspect\" \"true\"}." | |||
There was a problem hiding this comment.
While we're here you could add :optional and refer to those config keys
(good to keep them DRY with a simple def)
There was a problem hiding this comment.
Do you mean defing them in cider.nrepl.middleware.inspect and referring to them here?
There was a problem hiding this comment.
You probably mean using them twice, in inspect-refresh and in eval inspect true, but I can't find any mention of the latter in the docs.
There was a problem hiding this comment.
mmm I was assuming that the config keys {\"op\" \"eval\", \"inspect\" \"true\"} were already documented somewhere here. Maybe it's not the case as eval is not defined in cider-nrepl, IDK
Feel free to take it from here as deemed best
alexander-yakushev
force-pushed
the
inspect-refresh
branch
2 times, most recently
from
a2276e0
to
86c8562
Compare
alexander-yakushev
force-pushed
the
inspect-refresh
branch
2 times, most recently
from
849620a
to
ba445ca
Compare
|
Ready to be reviewed now. I also added the support for new |
alexander-yakushev
force-pushed
the
inspect-refresh
branch
from
ba445ca
to
606b0e1
Compare
alexander-yakushev
force-pushed
the
inspect-refresh
branch
from
606b0e1
to
a214f54
Compare
alexander-yakushev
force-pushed
the
inspect-refresh
branch
from
a214f54
to
bcc3087
Compare
|
Actually, sorry, let me walk back that decision. |
Sister to clojure-emacs/orchard#269. This is how it would look like on the cider-nrepl side. Old ops are retained for compatibility and marked as deprecated.