Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inspect] Introduce support for :view-mode config and inspect-toggle-view-mode op #879

Merged
merged 2 commits into from
May 30, 2024

Conversation

alexander-yakushev
Copy link
Member

  1. Adding :view-mode as a supported config options passed from CIDER to Orchard. This part is straightforward.
  2. Given that I wanted the view-mode to be a toggle, the best place for toggling logic is here. Adding it on CIDER side would require CIDER to know what is the current view-mode of the inspector which is extra work. cider-nrepl has that information though, so it's easy to do it here.

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

"view-mode" "Mode of viewing the value - either \"normal\" or \"object\""}
:returns inspector-returns}
"inspect-toggle-view-mode"
{:doc "Toggles the viewing mode of the inspector."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good place to list those and briefly explain what they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants