Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on folded nrepl dicts in the messages buffer results in an error #1568

Closed
bbatsov opened this issue Feb 14, 2016 · 7 comments
Closed
Labels
Milestone

Comments

@bbatsov
Copy link
Member

bbatsov commented Feb 14, 2016

We had this problem in the past, but @Malabarba fixed it. Guess we've got a regression.

@bbatsov bbatsov added the bug label Feb 14, 2016
@bbatsov bbatsov modified the milestone: v0.11 Feb 28, 2016
@bbatsov
Copy link
Member Author

bbatsov commented Feb 29, 2016

Just verified the old fix is here https://github.com/clojure-emacs/cider/blob/master/nrepl-client.el#L1287

I'm at a loss...

@bbatsov
Copy link
Member Author

bbatsov commented Feb 29, 2016

Just consulted the docs:

Perform the action specified by a button at location pos. pos may be either a buffer position or a mouse-event. If use-mouse-action is non-nil, or pos is a mouse-event (see Mouse Events), try to invoke the button’s mouse-action property instead of action; if the button has no mouse-action property, use action as normal. pos defaults to point, except when push-button is invoked interactively as the result of a mouse-event, in which case, the mouse event’s position is used. If there’s no button at pos, do nothing and return nil, otherwise return t.

Seems our code is correct, but for some reason the mouse-action is not registered at all.

@Malabarba
Copy link
Member

It might be an emacs bug. I'll try to reproduce on 25.1 tomorrow.

@bbatsov
Copy link
Member Author

bbatsov commented Mar 1, 2016

Yeah, maybe. That'd be fun. :-)

@Malabarba
Copy link
Member

Ok, it's definitely an Emacs bug that only happens for overlay-buttons with display properties. I've filed it upstream.

@bbatsov
Copy link
Member Author

bbatsov commented Mar 1, 2016

Any workaround ideas?

@Malabarba
Copy link
Member

Yeah, I was working on it. Can't believe I spent half an hour on this. This is really one of Emacs dark corners. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants