Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break the text in the error field of cider-test-error-report #1707

Closed
expez opened this issue Apr 22, 2016 · 4 comments
Closed

Break the text in the error field of cider-test-error-report #1707

expez opened this issue Apr 22, 2016 · 4 comments

Comments

@expez
Copy link
Member

expez commented Apr 22, 2016

Here is an example of how the error of a failing test:

image

The problem I'm having is that this is quite unreadable, as it's just one long line and I have to scroll to read it all.

If I hit RET on the error to get the stracktrace buffer to popup, I can read the message with proper text breaks. This is now my current workflow.

It looks this is just dumping the ExceptionInfo on one line. Perhaps we can split it into msg and cause and wrap the message text so it's readable without scrolling?

@Malabarba
Copy link
Member

Formatting the exception cause message does make sense to me. I've ran into that problem as well.

@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2016

Yeah, there's definitely room for improvement here. I wonder why the line wasn't wrapped though, as I seem to recall such long messages were wrapped for me.

@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2016

@jeffvalk Any thoughts on this?

@jeffvalk
Copy link
Contributor

jeffvalk commented Jul 11, 2016

I seem to recall that wrapping the error text broke some other formatting, so I kept it simple. That made sense then, but I certainly agree it would be better wrapped.

bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 10, 2016
bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 15, 2016
bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 15, 2016
bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 15, 2016
bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 15, 2016
bkruczyk added a commit to bkruczyk/cider that referenced this issue Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants