Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the performance of the nREPL message log #1859

Closed
bbatsov opened this issue Oct 7, 2016 · 4 comments
Closed

Optimize the performance of the nREPL message log #1859

bbatsov opened this issue Oct 7, 2016 · 4 comments

Comments

@bbatsov
Copy link
Member

bbatsov commented Oct 7, 2016

As discussed in #1758 the nREPL message logging is pretty slow (especially when big data structures are involved) and enabling logging causes constant freezes.

To alleviate the problem logging was disabled by default, but we still need to analyze and optimize the problematic code (nrepl--pp seems to be the main culprit here).

//cc @vspinu

@vspinu
Copy link
Contributor

vspinu commented Oct 7, 2016

The issues seem to be coming from pp-to-string. It shouldn't be hard to get rid of it.

@bbatsov
Copy link
Member Author

bbatsov commented Oct 7, 2016

@vspinu Can you look into this?

@vspinu
Copy link
Contributor

vspinu commented Oct 7, 2016

Sure. I will have a look over the weekend.

@bbatsov
Copy link
Member Author

bbatsov commented Oct 8, 2016

@vspinu Thanks!

vspinu added a commit to vspinu/cider that referenced this issue Oct 10, 2016
vspinu added a commit to vspinu/cider that referenced this issue Oct 10, 2016
vspinu added a commit to vspinu/cider that referenced this issue Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants