Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When disabling a theme, faces are not updated accordingly. #1987

Closed
ustun opened this issue May 9, 2017 · 0 comments
Closed

When disabling a theme, faces are not updated accordingly. #1987

ustun opened this issue May 9, 2017 · 0 comments

Comments

@ustun
Copy link
Contributor

ustun commented May 9, 2017

Previously, we were only updating faces when we enable themes.

We need to update the faces whenever a theme is disabled, otherwise after disabling a dark theme like molokai, the background colors are still black in the default emacs theme.

Expected behavior

When disabling a theme, backgroud colors of error reports etc should be re-calculated.

Actual behavior

Previous theme's colors are taken into account when disabling a theme.

Steps to reproduce the problem

Enable a theme on emacs startup. (possibly a dark one)
Start cider.
Disable theme.
Run a failing test.
The background color for tests still are like that of the disabled theme.

Before

image

After

image

Environment & Version information

CIDER version information

;; CIDER 0.15.0snapshot (package: 20170506.1322), nREPL 0.2.12
;; Clojure 1.8.0, Java 1.8.0_45

Lein/Boot version

Leiningen 2.7.1 on Java 1.8.0_45 Java HotSpot(TM) 64-Bit Server VM

Emacs version

GNU Emacs 25.2.1 (x86_64-apple-darwin16.5.0, Carbon Version 157 AppKit 1504.82) of 2017-04-28

Operating system

macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant