Update various faces when a theme is disabled #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only updating faces when we enable themes.
ustun
force-pushed
the
fix_disable_theme_color_fix
branch
from
88f0558
to
79e9c1c
Compare
|
👍 |
xiongtx
reviewed
May 10, 2017
| @@ -135,6 +135,11 @@ | |||
| "When theme is changed, update `cider-docview-code-background-color'." | |||
| (setq cider-docview-code-background-color (cider-scale-background-color))) | |||
|
|
|||
|
|
|||
| (defadvice disable-theme (after cider-docview-adapt-to-theme activate) | |||
There was a problem hiding this comment.
Why not use advice-add from nadvice.el? It's the recommended way for newer versions of Emacs.
There was a problem hiding this comment.
The thought crossed my mind as well, but we'd have to update the existing code for consistency as well. We can always do this down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1987