Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression - Cider no longer asks to reuse clj REPL buffers #3353

Closed
yuhan0 opened this issue Jun 15, 2023 · 0 comments · Fixed by #3354
Closed

Regression - Cider no longer asks to reuse clj REPL buffers #3353

yuhan0 opened this issue Jun 15, 2023 · 0 comments · Fixed by #3354

Comments

@yuhan0
Copy link
Contributor

yuhan0 commented Jun 15, 2023

Expected behavior

Cider asks to reuse dead clj REPLs.

Actual behavior

The refactoring in 4004862
essentially turned (eq repl-cljs? params-cljs?) into (and repl-cljs? params-cljs?), which is not a valid transformation - when both predicates are false, ie having a dead clj repl and trying to start a new clj one, it should evaluate to true and offer to reuse the repl.
yuhan0 added a commit to yuhan0/cider that referenced this issue Jun 15, 2023
@yuhan0
Restore ability to reuse dead clj REPLs
720d6b8 
Fixes clojure-emacs#3353
Partially reverts 4004862
@yuhan0 yuhan0 mentioned this issue Jun 15, 2023
Merged
6 tasks
bbatsov pushed a commit that referenced this issue Jun 16, 2023
@yuhan0 @bbatsov
Restore ability to reuse dead clj REPLs
a903e9e 
Fixes #3353
Partially reverts 4004862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve prompts for reusing dead REPLs yuhan0/cider
1 participant
@yuhan0