Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in echo area replaced by eldoc information #652

Closed
expez opened this issue Jun 26, 2014 · 6 comments
Closed

Error in echo area replaced by eldoc information #652

expez opened this issue Jun 26, 2014 · 6 comments

Comments

@expez
Copy link
Member

expez commented Jun 26, 2014

When you jump to an error, the cause is briefly visible in the modeline, but is quickly replaced by the eldoc output displaying the function signature. I propose we let the stacktrace information take precedence, in situations where both types of information are available.

@bbatsov
Copy link
Member

bbatsov commented Jul 12, 2014

Not sure if this is possible at all. I'll have to investigate the issue further. Can you add some steps to reproduce the exact problem you're experiencing?

@expez
Copy link
Member Author

expez commented Jul 15, 2014

(defn foo []
  (let [bar]))

Now hit M-n to move to the error. If you keep hitting M-n you'll briefly see the compiler exception in the echo area: "let requires an even number of forms...", otherwise the echo area will show eldoc for defn

As an aside, am I viewing the compiler exceptions in the intended manner? As I develop interactively I'm constantly hitting C-c C-k to reload the current file, and then viewing the compiler exceptions in the repl.

@bbatsov
Copy link
Member

bbatsov commented Jul 15, 2014

That's was done after a discussion with @pjstadig in #572. Output from interactive evaluation can now be sent to the REPL (default) or a dedicated output buffer (see cider-interactive-eval-output-destination). I guess I can add an option to send it to the minibuffer as well (as it used to be).

@expez
Copy link
Member Author

expez commented Jul 15, 2014

Right, my concern isn't where the output goes but that the compilation error is briefly shown in the echo area, but then replaced with eldoc information before one has any time to review it. Either we shouldn't attempt to display the compilation error in the echo area at all, or find some way to mute eldoc while visiting a line with an error. I prefer the latter.

@bbatsov
Copy link
Member

bbatsov commented Jul 17, 2014

Well, the same output is available in the stacktrace buffer anyways, but I see your point. I'll see if I can't add a check based on whether the last invoked command was next-error or previous-error.

@expez
Copy link
Member Author

expez commented Aug 12, 2014

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants