Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1659] Add fringe indicators for evaluated forms #1691

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

Malabarba
Copy link
Member

Out of all the fringe bitmap options, these 4 are the ones that seem most appropriate.
Not sure which one to use though.
screenshot-2016-04-18--194945-0300

@bbatsov
Copy link
Member

bbatsov commented Apr 18, 2016

I like option 1 and 4 the most.

@expez
Copy link
Member

expez commented Apr 19, 2016

Does the face also work as a setting? E.g. if I set the face to nil it won't draw anything?

@Malabarba
Copy link
Member Author

@expez No. We'll have to make a variable for that.

@bbatsov
Copy link
Member

bbatsov commented Apr 19, 2016

I'm guessing we'll have one for evaluations which resulted in an error. An maybe one for evals that produced warnings (not sure about this one).

We should also mention this in the changelog.

@Malabarba Malabarba merged commit 41e22ed into master Apr 21, 2016
@Malabarba Malabarba deleted the fringe-indicators branch April 21, 2016 00:00
@Malabarba
Copy link
Member Author

I've only implemented the evaluation indicator for now. I'd like to do the error too eventyually.
There's also a custom option to disable this.

@vspinu
Copy link
Contributor

vspinu commented Jun 28, 2017

What was the motivation behind this? I always start with loading the entire buffer, thus all forms end up having this fringe marker. To me it seems like a useless functionality which also interferes with other packages (#2018).

I am looking into fixing #2018 but I think for the long run it would be better to entirely remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants