Integrate ns-vars-with-meta op #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| "Return font-lock-face for TEXT. | ||
| The var info is fetched from the running repl and a font-lock face is decided. | ||
| (defun cider-browse-ns--text-face (var-meta) | ||
| "Return font-lock-face for a var. VAR-INFO is its metadata information. |
There was a problem hiding this comment.
The docstring will produce checkdoc warnings.
|
Overall the changes look good to me. |
|
Done :-) |
| "Return font-lock-face for TEXT. | ||
| The var info is fetched from the running repl and a font-lock face is decided. | ||
| (defun cider-browse-ns--text-face (var-meta) | ||
| "Return font-lock-face for a var. VAR-META is its metadata information. |
There was a problem hiding this comment.
The first line of a docstring should be just one sentence.
The current ns-browser relies on the `cider-repl-ns-cache` to decide font-locks. This gives us incorrect font-locks for namespaces which are present on the classpath, but not loaded in the REPL. We change this to get the data from the nREPL middleware op `ns-vars-with-meta`,in case of a cache miss; clojure-emacs/cider-nrepl#346.
|
|
||
| (declare-function cider-resolve-ns-symbols "cider-resolve") | ||
|
|
||
| (defun cider-ns-vars-with-meta (ns) |
There was a problem hiding this comment.
I don't think we need this anymore. Now that we have an op that returns exactly what we need, there's no need to use the cache. It complicates the code and has no advantage (now that the real op is fast enough).
There was a problem hiding this comment.
This only has an advantage when fetching huge namespaces, like the core ns'. But yeah, this fn could be avoided. I'll submit a PR today.
ajchemist
pushed a commit
to ajchemist/cider
that referenced
this pull request
Apr 25, 2016
…aded in the REPL (clojure-emacs#1710) The current ns-browser relies on the `cider-repl-ns-cache` to decide font-locks. This gives us incorrect font-locks for namespaces which are present on the classpath, but not loaded in the REPL. We change this to get the data from the nREPL middleware op `ns-vars-with-meta`,in case of a cache miss; clojure-emacs/cider-nrepl#346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test)M-x checkdocwarningsThanks!
The current ns-browser relies on the
cider-repl-ns-cacheto decide font-locks.This gives us incorrect font-locks for namespaces which are present on the classpath,
but not loaded in the REPL.
We change this to get the data from the nREPL middleware op
ns-vars-with-meta,in case of a cache miss; clojure-emacs/cider-nrepl#346.