Handle lone carriage returns as newline #1814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test
)M-x checkdoc
warningsSubstitute newline for single carriage returns
#1677
this doesn't totally solve the issue actually. The issue poster was hoping that "foo\rbar" would right foo, return to the beginning of the same line, and then write bar. However, we were stripping carriage returns with no action. We now act as lein repl does, replacing this lone carriage returns with newlines.
The fundamental issue was that text-based status bars didn't work, and it sounds like we don't have plans to fix this, or at least not at the moment. There are lots of things to consider like markers, how we parse up the bencoded string to know when to move to next line, when to zap over current line, etc, and that would be a much larger change.