Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ns when requiring repl utils #2730

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

dpsutton
Copy link
Contributor

Requiring repl utils did not send the current ns, so they were always required into the user namespace, not into the current ns.

(-->
  id                       "55"
  op                       "eval"
  session                  "4ecbc22b-1107-4070-8c15-8659413e1479"
  time-stamp               "2019-10-12 09:26:43.125825653"
  code                     "(clojure.core/apply clojure.core/require clojure.main/repl-r..."
  inhibit-cider-middleware "true"
)
(<--
  id         "55"
  session    "4ecbc22b-1107-4070-8c15-8659413e1479"
  time-stamp "2019-10-12 09:26:43.130607785"
  ns         "user"    ;; note that these were evaled in user since no ns was supplied
  value      "nil"
)
(<--
  id         "55"
  session    "4ecbc22b-1107-4070-8c15-8659413e1479"
  time-stamp "2019-10-12 09:26:43.131230533"
  status     ("done")
)

@dpsutton dpsutton force-pushed the repl-utils-include-ns branch from d3059cf to ec025eb Compare October 12, 2019 14:40
@dpsutton dpsutton force-pushed the repl-utils-include-ns branch from ec025eb to 2cd9a7f Compare October 12, 2019 14:47
@bbatsov bbatsov merged commit 6764c6c into clojure-emacs:master Oct 13, 2019
@bbatsov
Copy link
Member

bbatsov commented Oct 13, 2019

Great catch! Thanks!

@dpsutton dpsutton deleted the repl-utils-include-ns branch October 26, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants