Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to cider-symbol-at-point #2826

Merged
merged 4 commits into from
Mar 28, 2020
Merged

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Mar 27, 2020


Trim leading quotes from symbol, now that clojure-mode treats it as a symbol constituent:
clojure-emacs/clojure-mode#559

This makes it possible to use cider-doc, eldoc, and various other features on symbols with quotes in them like foo'.

Also uses macroexpand to resolve ns-aliased keywords, allowing cider-browse-spec to work on aliased keywords at point.
(Not sure how to write tests for this one)

Would this go under the "changes" or "new features" heading of the changelog?


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@bbatsov
Copy link
Member

bbatsov commented Mar 27, 2020

Would this go under the "changes" or "new features" heading of the changelog?

Let's go with changes.

@bbatsov bbatsov merged commit dfc13f9 into clojure-emacs:master Mar 28, 2020
@bbatsov
Copy link
Member

bbatsov commented Mar 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants