Support watching several shadow-cljs builds. #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageneau
force-pushed
the
shadow-init
branch
3 times, most recently
from
818ba0c
to
94a62a9
Compare
bbatsov
reviewed
Dec 10, 2020
cider.el
Outdated
| (defcustom cider-shadow-watched-builds nil | ||
| "Defines the list of builds `shadow-cljs' should watch." | ||
| :type '(repeat string) | ||
| :package-version '(cider . "0.26.2")) |
bbatsov
reviewed
Dec 10, 2020
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### New features | |||
|
|
|||
| * [#2909](https://github.com/clojure-emacs/cider/issues/2909): Add new customization variable `cider-inspector-auto-select-buffer` to control the auto selection of the inspector buffer. | |||
| * Add a new customization variable cider-shadow-watched-builds to allow watching several shadow-cljs builds at the same time. | |||
|
Apart from my small remarks, your changes look good. |
Add a cider-shadow-watched-builds customization variable which is the list of builds to watch. If not defined fallback on watching the default build set in cider-shadow-default-options or prompt the user.
|
PR updated with your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support watching several shadow-cljs builds.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.