add an interactive function cider-eval-last-sexp-to-kill-ring #3143
Conversation
takes an optional `pretty` argument stores the eval result in the kill ring there was some discussion about this feature here clojure-emacs#2580
| (if (derived-mode-p 'cider-clojure-interaction-mode) | ||
| (format "\n%s\n" value) | ||
| value)) | ||
| (copy-region-as-kill (point-min) (point-max)))) |
There was a problem hiding this comment.
This doesn't look correct to me as you'll be adding to the clipboard each chunk of the response (provided it's big enough to the split into several response messages). Normally you'd want to collect all the chunks until you get "done" and only then copy something to the clipboard.
There was a problem hiding this comment.
Also - it seems to me it would still be a goo idea to echo somewhere the result, so you'd know what ended up in the kill-ring without having to check it.
| (cider-interactive-eval nil | ||
| (cider-eval-kill-ring-handler) | ||
| (cider-last-sexp 'bounds) | ||
| ;; this says that it does NOT require pretty printing... add an option? |
There was a problem hiding this comment.
I'm not quite sure what this is supposed to mean.
|
I think it would be better to reserve one of Emacs' built-in registers for this, and always copy the result of any interactive eval into it - something like (defcustom cider-eval-register ?e
"When non-nil, save the last eval result into this register"
:type '(choice character (const nil)))Then instead of having to consciously call a dedicated eval-to-kill-ring command/ family of commands, one could decide after any regular |
|
Or alternatively, have a command which prints the repl's |
|
Yeah, I think that's a better and simpler approach. PR welcome! |
|
Which approach would you prefer? Auto saving to register (might be less discoverable) or adding a |
|
@yuhan0 I was actually thinking of doing both, as they are not mutually exclusive. :D Probably with a defcustom to enable the auto-save to register behavior. |
|
@yuhan0 Any chance you'll find a time for this soon? I'm thinking of cutting a new CIDER release in March, and it'd be nice if this made the cut. |
|
Oh yes, I'll submit a PR in the next day or two. |
|
Closing this in favour of #3162. |
This is my first attempt to contribute to cider, please consider this PR a draft. I am no elisp expert, I welcome feedback. I read the CONTRIBUTING guidelines but I must confess that I did not understand all of them.
This is a feature that I'd been wanting: eval, storing the eval result in the kill ring
takes an optional
prettyargumentstores the eval result in the kill ring
there was some discussion about this feature here
#2580
It's based on
masteras of this morning, I'm using emacs built from source fairly recently:I'm using native-compilation
I did not add a default keybinding in this commit. The keybindings I use for cider are very different from the defaults and so I don't feel qualified to suggest a reasonable default keybinding for this.