-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: multiple persistent eval overlays #3149
Conversation
cider-eval.el
Outdated
@@ -897,7 +897,10 @@ arguments and only proceed with evaluation if it returns nil." | |||
(start (car-safe bounds)) | |||
(end (car-safe (cdr-safe bounds)))) | |||
(when (and start end) | |||
(remove-overlays start end 'cider-temporary t)) | |||
;; NOTE: `remove-overlays' splits and leaves behind partial overlays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this comment could be more verbose?
e.g. NOTE: please don't use remove-overlays, as it splits and leaves behind partial overlays. See <source>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess to the issue, but I don't have a strong preference here, as long as it's clear what we're avoiding.
I like the proposed change. Let's just document this somewhere (I'm not sure if we've even documented the old two options) and illustrated the differences with a couple of animated gifs like the one you've used in the PR description. |
08f3b0b
to
77b3e01
Compare
77b3e01
to
b94be7c
Compare
Ok, I've updated the changelog and manual, also another commit that I accidentally missed out from the last PR. |
Thanks! |
This adds a third option
'change
tocider-eval-result-duration
, which persists eval overlays until there is a change to the buffer, allowing for easy comparisons between different forms.A quick demo:
Note: This is how Calva behaves, see the demo at https://calva.io/try-first/
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.