Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply colorization on actual/expected test output #3177

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Apr 5, 2022

For matchers like matcher-combinators that rely on that.

Closes #2901

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

For matchers like matcher-combinators that rely on that.
@plexus
Copy link
Contributor Author

plexus commented Apr 5, 2022

The build failures seem to be unrelated.

@plexus plexus force-pushed the arne/colorize-test-assertion branch from 9ae4d2d to 9b56d45 Compare April 5, 2022 09:32
@vemv
Copy link
Member

vemv commented Apr 5, 2022

Looks reasonable, could you attach a before/after as screenshots?

@plexus
Copy link
Contributor Author

plexus commented Apr 5, 2022

2022-04-05_115443_Emacs
2022-04-05_115513_Emacs

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fonts btw 🍵🍵

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: vemv <vemv@users.noreply.github.com>
@plexus plexus merged commit db972bb into master Apr 5, 2022
@plexus plexus deleted the arne/colorize-test-assertion branch April 5, 2022 12:16
@plexus
Copy link
Contributor Author

plexus commented Apr 5, 2022

It's Iosevka <3

@ericdallo
Copy link
Contributor

At Nubank we had a workaround defadivce to fix that for macher-combinators but we never found how to solve on Cider, thank you for that @plexus !

@plexus
Copy link
Contributor Author

plexus commented May 3, 2022

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better output of matcher-combinators on tests
3 participants