Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scale down time for overlay tests on MacOS #3289

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

pestctrl
Copy link
Contributor

Overlay tests involve testing the timer functionality of overlays, and require the use of sleep. The tests scale all time-related arguments by a certain factor to avoid overly inflating test-running times.

The scaling factor was initially set at 1 order of magnitude slower than the consistently succeeding value on my machine, but the value is apparently still too fast for the MacOS test runner, so I have added MacOS to the list of platforms unsafe to do this optimization for.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@pestctrl pestctrl force-pushed the consecutive-overlays branch from fe7fc26 to 1fa7a67 Compare December 11, 2022 14:30
Overlay tests involve testing the timer functionality of overlays, and
require the use of sleep. The tests scale all time-related arguments
by a certain factor to avoid overly inflating test-running
times.

The scaling factor was initially set at 1 order of magnitude slower
than the consistently succeeding value on my machine, but the value is
apparently still too fast for the MacOS test runner, so I have added
MacOS to the list of platforms unsafe to do this optimization for.
@ikappaki
Copy link
Contributor

Hi, just to clarify, the macos tests have moved to circleci under ci/circle: test-macos-emacs-latest with #3278 and it is green now with this PR:

image

So I think this PR is good to go.

@bbatsov bbatsov merged commit 5f16f16 into clojure-emacs:master Dec 11, 2022
@bbatsov
Copy link
Member

bbatsov commented Dec 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants