-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new inspector function to tap current value #3549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Co-authored-by: vemv <vemv@users.noreply.github.com>
…nto inspectorTapCurrentValue
Co-authored-by: vemv <vemv@users.noreply.github.com>
Might be good to expand on this a bit in the debugging techniques/inspector part of the docs. |
I added in docu a TIP to tap values from inspector in order to render them graphically using other tools. |
I would have one more question on this PR. This gets complicated by the fact, that the user would need to give "feedback" when this happens. The example is "having a map deep in a value which represents 'vega-lite' data" We had as well a discussion on this here: #3311 Do you think the current code of this PR allows this easely, as an extension by using "advice" for example ? |
I got these changed into 966cae4 preserving attribution. Thanks much!
Probably not, but feel free to give it a try. A clean solution would be to make the cider-nrepl accept a Users could bind a specific key in the inspector map to perform Lastly, I dropped the path code, it turned out to excessively complicate things. It would be easier if cider-nrepl simply returned a (well-formed!) :path as part of every reponse that included a |
add new interactive function
cider-inspector-tap-current-val
to inspector.It sends the current inspector value to the tap>.
It uses a new middleware op,
inspect-tap-current-value
which has been added recently to cider-nrepl.Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.