Possibly display error overlays on cider-load-buffer
#3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Nov 6, 2023
| (let* ((phase (cider--error-phase-of-last-exception buffer)) | ||
| ;; 2.- Calculate the overlay position, which is the point (per the previous jump), | ||
| ;; and then end-of-line (for ensuring the overlay will be rendered properly): | ||
| (end (save-excursion |
There was a problem hiding this comment.
Won't this be problematic on long lines? I think it's probably best to just have the overlay at the point's position after the jump to the error line.
There was a problem hiding this comment.
Without this, the overlay (as defined deeper in our codebase) would be rendered in the previous top sexpr's end line, which was very confusing.
Anyway, I coded that (unawarely) assuming cider-result-overlay-position == 'at-eol.
I'll adapt it to work with both possible user choices - after that we should have something pretty acceptable and that follows the existing defcustom's semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified locally that it works nicely.
Cheers - V