Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show friendly error message if symbol is not found on ClojureDocs #3689

Merged
merged 2 commits into from
May 30, 2024
Merged

Show friendly error message if symbol is not found on ClojureDocs #3689

merged 2 commits into from
May 30, 2024

Conversation

katomuso
Copy link
Contributor

When we use cider-clojuredocs, it shows the error message Wrong type argument: char-or-string-p, nil if a symbol we are looking for is not found. It will be nice if it will show something more meaningful instead.

@bbatsov
Copy link
Member

bbatsov commented May 30, 2024

I'm fine with the proposed change, just mention the bugfix in the changelog.

P.S. I'll be cutting a new release of CIDER soon, so this would be a good time to also add some documentation about cider-cheatsheet with a few screenshots, etc.

@bbatsov bbatsov merged commit 605d409 into clojure-emacs:master May 30, 2024
32 checks passed
@katomuso
Copy link
Contributor Author

P.S. I'll be cutting a new release of CIDER soon, so this would be a good time to also add some documentation about cider-cheatsheet with a few screenshots, etc.

I was planning to add customizable variables for the cheatsheet tomorrow, and then update the documentation the day after tomorrow. Will this be in time for the new release?

@bbatsov
Copy link
Member

bbatsov commented May 30, 2024

Take your time, there's no rush. It will be late for this release, at it happened just now, but there's no problem to include those changes in the next one.

@katomuso katomuso deleted the clojuredocs-friendly-error-message branch May 30, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants