Support company-mode

[dgutov]

Continued from clojure-emacs/ac-nrepl#30.

So far the only bug I'm aware of is in cider-company-location: if cider-jump-to-def fails with namespace error, the handler just prints the error message with message, and the former function returns the current buffer. Should nrepl-make-response-handler use error in these situations?

Also note that it works differently from what @steckerhalter did in company-cider: instead of showing the output of clojure.repl/source, it actually opens the file where a given function is defined.

[bbatsov]

response -> RESPONSE

[bbatsov]

Overall the code looks good to me.

I guess using error in the handler makes sense. You should also update the CHANGELOG and rebase on top of the current master, so this can be cleanly merged.

[dgutov]

Updated, rebased and pushed.

Making nrepl-make-response-handler raise an error was a bust, it swallows it and doesn't show the message at all. So that's a +1 hack in cider-company-location. If you don't like this one, an alternative would be to save the current buffer and point, and compare the new values with them before returning, only if they're not equal.

By the way, when the cider middleware is used, the same error makes it spew a stack trace in a hidden buffer in background and apparently not respond to the request at all (Emacs waits indefinitely).

[bbatsov]

@dgutov That will do for now. I'll take a look at the middleware issue. //cc @gtrak

[bbatsov]

You might also report it here https://github.com/clojure-emacs/cider-nrepl, so we won't forget about it.

[dgutov]

Ah, I think it's clojure-emacs/cider-nrepl#7.