Three related patches on error handling.

[vspinu]

Three patches:

• Use file-truename consistently in cider-highlight-compilation-errors to avoid recognizing simplinked files as different.
• Add cider-auto-jump-to-error functionality.
• Print cider error messages into minibuffer. Most useful when cider-show-error-buffer is nil. This particular behavior was there a month ago. I assume it's a regression that I don't see it anymore in the HEAD.

[bbatsov]

This wasn't a regression, but a result of the discussion in #572.

[vspinu]

Well. I don't mind if it's printed in repl or not, but it should be printed in the echo area as well. I expect output in the minibuffer, error it is or not. It's especially inconsistent and confusing when stacktrace is not automatically popped. I can check for the value of the cider-show-error-buffer and conditionally on that display the message. I think it's a good compromise.

[vspinu]

I have rewrote the api and addressed the error message issue as discussed.

[bbatsov]

The problem is that you think of this as the exception message, but it's actually ANY error output. The current concept is that people can use the output-destination defcustom to customize this, which is preferable to sprinkling message calls everywhere. I'd suggest taking this out of that PR so we can discuss it separately.

[vspinu]

Ok, I have dropped that part. I don't mind how it is implemented as long as I see the message;)

[bbatsov]

Overall the code looks good now. I just have a few minor stylistic remarks. You'll do well to use M-x checkdoc to make sure your code conforms to the established Emacs Lisp style.

[vspinu]

Ok. I have corrected the doc issues. Didn't know about M-x checkdoc.

There are quite some other pre-existing issues that checkdoc complains about. Not all of them are real errors, but it makes the checks harder.

[bbatsov]

👍