-
Notifications
You must be signed in to change notification settings - Fork 112
cljr-slash triggers within keywords #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report, the current situation is clearly unacceptable! |
having second thoughts about this. a namespaced keyword needs a require so triggering |
Only if it uses a double-colon ( |
Don't call lookup-alias for non namespaced keywords at all when slash is typed. However trigger lookup alias with the leading :: stripped off the prefix if the keyword is namespaced. - rename `cljr--is-keyword?` -> `cljr--sans-ns-keyword?`
Don't call lookup-alias for non namespaced keywords at all when slash is typed. However trigger lookup alias with the leading :: stripped off the prefix if the keyword is namespaced. - rename `cljr--is-keyword?` -> `cljr--sans-ns-keyword?`
Don't call lookup-alias for non namespaced keywords at all when slash is typed. However trigger lookup alias with the leading :: stripped off the prefix if the keyword is namespaced. - fix bug in `cljr--keyword?` so it recognises aliased, `::` keywords
[Fix #305] Handle keywords in `cljr-slash` Don't call lookup-alias for non namespaced keywords at all when slash is typed. However trigger lookup alias with the leading :: stripped off the prefix if the keyword is namespaced.
I write lots of Datomic queries which contain keywords with slashes in them (e.g.
:artist/name
), and I wish cljr-slash didn't trigger each time I wrote one as it interrupts for a noticeable instant my typing flow.I see that cljr uses
cider-in-comment-p
andcider-in-string-p
to decide on whether it must trigger. I wonder if one could add a check for keywords as well?The text was updated successfully, but these errors were encountered: