Skip to content

cljr-clean-ns easy fix #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
boymaas opened this issue Jun 2, 2019 · 2 comments
Closed

cljr-clean-ns easy fix #442

boymaas opened this issue Jun 2, 2019 · 2 comments

Comments

@boymaas
Copy link

boymaas commented Jun 2, 2019 •
edited
Loading

Excuses no time to fill in the complete form. Just a quick pointer, got the following error string-prefix-p: Wrong type argument: stringp, nil when trying to use cljr-clean-ns. A quick debug shows a very quick fix.

clj-refactor.el/clj-refactor.el

Lines 2738 to 2740 in 9f508bb

(let ((path (or path (buffer-file-name)))
(relative-path (cljr--project-relative-path path)))
(when-let (new-ns (cljr--call-middleware-sync

It uses a let which I believe should be a let*. Wondering why this was not noticed before.

Thanks for a great library!!
@expez
Copy link
Member

expez commented Jun 2, 2019

Thanks for the report!

Wondering why this was not noticed before.

This code path was added about a month ago and is used only in some situations.

iarenaza added a commit to iarenaza/clj-refactor.el that referenced this issue Aug 27, 2020
@iarenaza
Send nREPL-based paths instead of CIDER-based paths
33b57c8 
When `cider-path-translations` is in use (e.g., when CIDER is running
on the host, but the nREPL is running in a VM or a Docker container)
we need to translate the local CIDER-based paths to the remote
nREPL-based paths for those operations that send paths to nREPL.

We use the new `cider-to-nrepl-filename-function` that is introduced
in CIDER pull request #2897, that should be applied before this one.

Also includes a fix for clojure-emacs#442.
@iarenaza iarenaza mentioned this issue Aug 27, 2020
Merged
6 tasks
expez pushed a commit that referenced this issue Aug 31, 2020
@iarenaza @expez
Send nREPL-based paths instead of CIDER-based paths
e63a41d 
When `cider-path-translations` is in use (e.g., when CIDER is running
on the host, but the nREPL is running in a VM or a Docker container)
we need to translate the local CIDER-based paths to the remote
nREPL-based paths for those operations that send paths to nREPL.

We use the new `cider-to-nrepl-filename-function` that is introduced
in CIDER pull request #2897, that should be applied before this one.

Also includes a fix for #442.
@expez
Copy link
Member

expez commented Aug 31, 2020

solved

@expez expez closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boymaas @expez