[refactor] Use Elisp style, -p predicates
#317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me. And the last section of the commit is a reminder that it's better to use seq and subr-x in the long run (for pretty much the same reasons). |
| @@ -724,7 +724,7 @@ at the opening parentheses of an anonymous function." | |||
| (when (<= (point) search-bound) | |||
| (error "Can't find definition of anonymous function!"))))))) | |||
|
|
|||
| (defun cljr--even? (n) | |||
| (defun cljr--even-p (n) | |||
There was a problem hiding this comment.
This should've been cljr--evenp. There's only a hyphen before the p if there's a hyphen in the predicate.
See more here if you're really interested.
There was a problem hiding this comment.
Ah, yes. Even I forgot about this.
|
Great work @benedekfazekas! |
benedekfazekas
force-pushed
the
b-style-preds
branch
from
b6bff9f to
b636338
Compare
As discussed in #311 `-p` style predicates are more consistent with the rest of clojure-emacs projects and the language in general. cljr predicates renamed - cljr--use-multiple-cursors? - cljr--comment-line? - cljr--whitespace? - cljr--inside-prefixed-libspec-vector? - cljr--even? - cljr--op-supported? - cljr--cljs-file? - cljr--cljc-file? - cljr--clj-file? - cljr--dash-in-file-name? - cljr--already-declared? - cljr--existing-group-of-defs? - cljr--point-in-reader-conditional? - cljr--point-in-reader-conditional-branch? - cljr--clj-context? - cljr--in-namespace-declaration? - cljr--excluded-from-project-clean? - cljr--empty-buffer? - cljr--end-of-buffer? - cljr--qualified-symbol? - cljr--is-keyword? - cljr--symbol? - cljr--keyword-lookup? - cljr--defn? - cljr--call-site? - cljr--no-changes-to-parameter-order? - cljr--apply-call-site? - cljr--partial-call-site? - cljr--ignorable-occurrence? predicates renamed from dependencies - -contains? (dash) - -every? (dash) - s-contains? (s) - s-starts-with? (s) - s-ends-with? (s) - s-equals (s) - s-matches? (s) predicates with extra hypen - cljr--toplevel-p - cljr--whitespace-p - cljr--defn-p - cljr--asts-p predicates not renamed as there is no suitable alias - s-blank? (s) - s-present? (s) - s-uppercase? (s)
benedekfazekas
force-pushed
the
b-style-preds
branch
from
b636338 to
c79ff74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #311
-pstyle predicatesare more consistent with the rest of clojure-emacs projects and the
language in general.
cljr predicates renamed
predicates renamed from dependencies
predicates not renamed as there is no suitable alias