Let user specify default language context #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user enters an apparent namespace like `somelib/`, and the language context is ambiguous, clj-refactor creates a popup asking the user to specify whether the context is "clj" or "cljs". This change allows the user to specify a language context which should be assumed, so that clj-refactor will choose that context in ambiguous cases rather than creating a popup. Default behavior is still to create the popup; this change only creates a variable that lets the user override that behavior. Tested fairly extensively at REPL; it didn't seem substantial enough to warrant a new automated test (especially since I've never worked with Cucumber).
|
Thanks for digging into this @eggsyntax! 👍 This looks mergeworthy to me but I'll give @benedekfazekas a chance to chime in. Could you also create a changelog entry? I'm sure other people might be interested in this too! :) |
|
no objections here!
…On 13 Nov 2017 10:01 a.m., "Lars Andersen" ***@***.***> wrote:
Thanks for digging into this @eggsyntax <https://github.com/eggsyntax>! 👍
This looks mergeworthy to me but I'll give @benedekfazekas
<https://github.com/benedekfazekas> a chance to chime in.
Could you also create a changelog entry? I'm sure other people might be
interested in this too! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#397 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9Pnmh0VDQcdZrZ30tjz_UHfzrf4t4Mks5s2BNYgaJpZM4Qa7dq>
.
|
|
@expez "Could you also create a changelog entry?" Totally happy to! I was going to, but it wasn't clear to me how I should do so, since the changelog is version-based, and I assume this doesn't warrant a version bump. Should I start a new section above the 2.3.1 section? |
Yes, something like this |
|
Changelog updated. Thanks, y'all! |
|
Fantastic work, @eggsyntax! Thanks a lot! 👍 |
|
My pleasure, thanks for accepting it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user enters an apparent namespace like
somelib/, andthe language context is ambiguous, clj-refactor creates a popup
asking the user to specify whether the context is "clj" or "cljs".
This change allows the user to specify a language context which
should be assumed, so that clj-refactor will choose that context
in ambiguous cases rather than creating a popup. Default behavior
is still to create the popup; this change only creates a variable
that lets the user override that behavior.
Tested fairly extensively at REPL; it didn't seem substantial
enough to warrant a new automated test (especially since I've
never worked with Cucumber).
Resolves #394
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
** See above
cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el)./run-tests.sh)** Note: it wasn't clear to me how to add it to the changelog, since the changelog is version-based, and this didn't seem to warrant a version bump. Happy to add it if this is clarified.
** README points to
https://github.com/clojure-emacs/clj-refactor.el/wiki#customization, which just says how to pull up the set of available customizations (& this now comes up as part of that set).Thanks!