-
Notifications
You must be signed in to change notification settings - Fork 112
[Fix #426] Expose variable to ignore paths in the middleware #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c9d077
to
fbd2f16
Compare
@bbatsov While I'm in here, any idea about how to fix the build? |
@expez I see that the build is failing because CIDER's master now depends on Emacs 25.1 (as |
That fails because the group of the |
clj-refactor.el
Outdated
@@ -2484,6 +2488,7 @@ See: https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-promote-function | |||
"line" line | |||
"column" column | |||
"name" symbol | |||
"ignore-paths" cljr-middleware-ignore-paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if ignored-paths
won't be a better name for this, as normally I'd assume something named ignore-paths
means something else.
This makes it possible to easily exclude certain files and directories for analysis.
fbd2f16
to
4911203
Compare
This is done to match CIDER's requirements.
4911203
to
015a201
Compare
@bbatsov I renamed the variable in clj-refactor, but the variable name in the backend was already commited to when we released 2.3.1. |
Merged manually |
This makes it possible to easily exclude certain files and directories
for analysis.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
The code for this already exists in the middleware. Not sure why a setting was never created. Perhaps we just forgot?