Skip to content

[Fix #426] Expose variable to ignore paths in the middleware #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

expez
Copy link
Member

@expez expez commented Jul 8, 2018

This makes it possible to easily exclude certain files and directories
for analysis.

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

The code for this already exists in the middleware. Not sure why a setting was never created. Perhaps we just forgot?

@expez expez force-pushed the config-setting-to-ignore-certain-paths branch 2 times, most recently from 4c9d077 to fbd2f16 Compare July 8, 2018 08:10
@expez
Copy link
Member Author

expez commented Jul 8, 2018

@bbatsov While I'm in here, any idea about how to fix the build?

@bbatsov
Copy link
Member

bbatsov commented Jul 8, 2018

@expez I see that the build is failing because CIDER's master now depends on Emacs 25.1 (as sesman, the new connection management library depends on it). I guess you'll have to update the build matrix.

@bbatsov
Copy link
Member

bbatsov commented Jul 8, 2018

clj-refactor.el:289:1:Error: defcustom for ‘cljr-middleware-ignore-paths’ fails to specify containing group

That fails because the group of the defcustom is not specified. I guess you didn't configure the top-level group to just infer that everything starting with cljr should go to the same group.

clj-refactor.el Outdated
@@ -2484,6 +2488,7 @@ See: https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-promote-function
"line" line
"column" column
"name" symbol
"ignore-paths" cljr-middleware-ignore-paths
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if ignored-paths won't be a better name for this, as normally I'd assume something named ignore-paths means something else.

This makes it possible to easily exclude certain files and directories
for analysis.
@expez expez force-pushed the config-setting-to-ignore-certain-paths branch from fbd2f16 to 4911203 Compare July 8, 2018 12:32
This is done to match CIDER's requirements.
@expez expez force-pushed the config-setting-to-ignore-certain-paths branch from 4911203 to 015a201 Compare July 8, 2018 12:35
@expez
Copy link
Member Author

expez commented Jul 8, 2018

@bbatsov I renamed the variable in clj-refactor, but the variable name in the backend was already commited to when we released 2.3.1.

@expez
Copy link
Member Author

expez commented Jul 25, 2018

Merged manually

@expez expez closed this Jul 25, 2018
@expez expez deleted the config-setting-to-ignore-certain-paths branch July 25, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants