Handle string requires gracefully

[vemv]

Context

https://clojurians.zulipchat.com/#narrow/stream/180378-slack-archive/topic/cider/near/251080205

Brief

clj-suitable/src/main/suitable/compliment/sources/cljs/analysis.cljc

Line 259 in 223f890

{:pre [(symbol? ns)]}

has a :pre that won't play fine with shadow-cljs "string requires", leading to client errors whenever one of those requires is present.

Suggestion

If a ns is a string, instead of computing (meta (clojure.core/find-ns ns)), return {}.

Similar for any other place where "string requires" might be handled throughout the codebase

...Obviously, ideally clj-suitable would understand the "string requires" and offer actual functionality for them. Not sure if that's at hand though. So it seems sensible to at least avoid a hard failure.

[nwjsmith]

Just ran into this, although I'm not using shadow-cljs. ClojureScript's Library Property Namespaces can require string requires as well.

[vemv]

Released [org.rksm/suitable "0.4.1-alpha1"], feel free to try it out

[vemv]

Whoops, sorry, it's not as easy as bumping that dep isolatedly. We have to cut a cider-nrepl release that uses the new suitable.

[nwjsmith]

@vemv is there a way to override the version of suitable that cider-nrepl depends on in my local setup? I'd like to test this out if possible.

[vemv]

Not directly, however we can release cider-nrepl which you could refer to in cider.el

Relatedly, @bbatsov WDYT of making this defconst a defcustom instead? https://github.com/clojure-emacs/cider/blob/adfc1c940d452ace7d1dbea543024d422f60364c/cider.el#L409 Maybe we can split it into two as you mentioned earlier today.

(I'd suggest not introducing a micro breaking change with it)

[bbatsov]

Btw, constants in Elisp are not really constants - you can set this to whatever you want in your setup. And yeah - I'll likely add a defcustom for the injected cider-nrepl version.

[bbatsov]

Just made the necessary changes - see cider-injected-middleware-version.

[vemv]

Fix finally available in cider-20211002.1153.tar (i.e. today's CIDER snapshot published on MELPA) or via [org.rksm/suitable "0.4.1"] for other setups

@nwjsmith

[nwjsmith]

@vemv just tried it out and it's working great. Thanks for all your work on this.

[vemv]

Very happy to read that! 🍻