Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on seq #605

Merged
merged 3 commits into from
Nov 14, 2021
Merged

Conversation

ROCKTAKEY
Copy link
Contributor

I add (require 'seq), since seq-every-p is not autoloaded.
When it is installed by package.el, its absence causes byte-compile warning:

In end of data:
clojure-mode.el:3019:1:Warning: the function ‘seq-every-p’ is not known to be
    defined.

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

Since `seq-every-p` is not autoloaded.
@bbatsov
Copy link
Member

bbatsov commented Nov 14, 2021

Good catch. Alternatively we can just replace this with something from cl-lib to avoid loading the whole library for a single function.

@ROCKTAKEY
Copy link
Contributor Author

seq-every-p seems to be replaced with cl-every. Is it better?

@bbatsov
Copy link
Member

bbatsov commented Nov 14, 2021

Yeah, I think that'd be a better solution for this particular problem.

@ROCKTAKEY
Copy link
Contributor Author

OK, I will fix it.

@ROCKTAKEY
Copy link
Contributor Author

Fixed.

@bbatsov bbatsov merged commit 08986ac into clojure-emacs:master Nov 14, 2021
@bbatsov
Copy link
Member

bbatsov commented Nov 14, 2021

Thanks!

@ROCKTAKEY ROCKTAKEY deleted the add-seq-requirement branch November 14, 2021 08:07
@ROCKTAKEY ROCKTAKEY changed the title Add (require 'seq) Remove dependency on seq Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants