Skip to content

Update the ts grammar #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbatsov opened this issue Apr 10, 2025 · 5 comments · Fixed by #78
Closed

Update the ts grammar #77

bbatsov opened this issue Apr 10, 2025 · 5 comments · Fixed by #78
Labels
enhancement Enhancement to existing functionality

Comments

@bbatsov
Copy link
Member

bbatsov commented Apr 10, 2025

We're using version 0.0.12, but I've noticed there's also 0.0.13 now (https://github.com/sogaiu/tree-sitter-clojure/releases/tag/v0.0.13). @rrudakov Perhaps you wouldn't mind testing how things work with it?

@bbatsov bbatsov added the enhancement Enhancement to existing functionality label Apr 10, 2025
@bbatsov
Copy link
Member Author

bbatsov commented Apr 10, 2025

I'm guessing updating https://github.com/tree-sitter-grammars/tree-sitter-markdown/releases/tag/v0.4.1 might help with #60 - I see the version we're using is ancient at this point.

@rrudakov
Copy link
Contributor

I'll test it. From the changelog it looks like there were no any API changes.

@rrudakov
Copy link
Contributor

I'm guessing updating https://github.com/tree-sitter-grammars/tree-sitter-markdown/releases/tag/v0.4.1 might help with #60 - I see the version we're using is ancient at this point.

Will try it too.

My current guess is that range might be calculated incorrectly when you type in a single backtick in the docstring (because in this case the rest of the buffer is highlighted as a docstring), but I planned to investigate it in more details. Updating grammar is not a bad idea either.

@rrudakov
Copy link
Contributor

Note: our clojure-ts--ensure-grammars won't upgrade grammars if they were already installed (even if version is old). Maybe it would be a good idea to add clojure-ts-upgrade-grammars or something like that.

@bbatsov
Copy link
Member Author

bbatsov commented Apr 10, 2025

Yeah, that's a good idea.

rrudakov added a commit to rrudakov/clojure-ts-mode that referenced this issue Apr 10, 2025
@rrudakov rrudakov mentioned this issue Apr 10, 2025
4 tasks
rrudakov added a commit to rrudakov/clojure-ts-mode that referenced this issue Apr 10, 2025
rrudakov added a commit to rrudakov/clojure-ts-mode that referenced this issue Apr 11, 2025
bbatsov pushed a commit that referenced this issue Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants