Fix issue with fontification when markdown-inline is enabled #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 14, 2025
bbatsov
reviewed
Apr 14, 2025
| @@ -1380,7 +1389,6 @@ See `clojure-ts--font-lock-settings' for usage of MARKDOWN-AVAILABLE." | |||
| (let ((use-markdown-inline (and clojure-ts-use-markdown-inline | |||
| (treesit-ready-p 'markdown-inline t)))) | |||
| (when use-markdown-inline | |||
| (treesit-parser-create 'markdown-inline) | |||
There was a problem hiding this comment.
Ah, so this was not supposed to be used in this manner. Good to know!
There was a problem hiding this comment.
Yes, I actually tried to pass :local t to the range function but it didn't work because I didn't remove this line as well. It was a good idea to ask for help in Emacs-bugs mailing list.
|
Apart from my small remarks and the failing test - the changes look good to me. |
…is enabled Many thanks to Juri Linkov <juri@linkov.net> for his assistance.
rrudakov
force-pushed
the
feature/local-md-parser
branch
from
3139463 to
c71c33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to Juri Linkov juri@linkov.net for his assistance.
Close #60
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!