v2 plugin #23
Merged
v2 plugin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
force-pushed
the
plugin-v2
branch
5 times, most recently
from
ed03d57
to
e66185b
Compare
vemv
added a commit
to clojure-emacs/cider
that referenced
this pull request
Jul 5, 2023
Its new functioning is described in clojure-emacs/enrich-classpath#23
vemv
added a commit
to clojure-emacs/cider
that referenced
this pull request
Aug 12, 2023
Its new functioning is described in clojure-emacs/enrich-classpath#23
vemv
added a commit
to clojure-emacs/cider
that referenced
this pull request
Aug 19, 2023
Its new functioning is described in clojure-emacs/enrich-classpath#23
vemv
added a commit
to zenmacs/cider
that referenced
this pull request
Aug 22, 2023
Its new functioning is described in clojure-emacs/enrich-classpath#23
vemv
added a commit
to clojure-emacs/cider
that referenced
this pull request
Aug 25, 2023
Its new functioning is described in clojure-emacs/enrich-classpath#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new approach for the Lein plugin: now all what Enrich does is building a bespoke
javacommand, using the Lein project map (including any modifications from profiles, other plugins, etc) as the basis.This allows us to have a very precise control of classpath ordering, which Lein does not provide otherwise.
It's a similar approach to what we do for tools.deps. Except that we also launch an nrepl server, honoring Lein options. This relpaces
lein repl :headless.As a very nice side-effect, the resulting
javainvocation will involve just one JVM process, as opposed to the two JVMs that Lein traditionally involves.We still need a JVM for calculating the
javacommand. However that is amenable to caching - it's exactly what the official tools.deps CLI does. Could be done eventually.n.b. this is alpha software atm - I'll release this only for private testing.