Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding loggers #13

Closed
vemv opened this issue Jan 12, 2024 · 3 comments · Fixed by #15
Closed

Excluding loggers #13

vemv opened this issue Jan 12, 2024 · 3 comments · Fixed by #15
Assignees

Comments

@vemv
Copy link
Member

vemv commented Jan 12, 2024

I'd like to exclude certain loggers, e.g. org.eclipse.jetty.server.Server, org.eclipse.jetty.server.AbstractConnector

I don't think this is nicely expressable with the current filters.

  • pattern operates on the message, not logger
  • loggers is an allowlist, not a blocklist

So I was thinking of introducing a logger-pattern or loggers-blocklist. Maybe both.

Thoughts? @r0man

@r0man
Copy link
Collaborator

r0man commented Jan 13, 2024

Sounds good to me. Maybe choose a more obvious name? rename loggers to included-loggers, and use excluded-loggers?

@vemv
Copy link
Member Author

vemv commented Jan 13, 2024

I guess we can perform that breaking change and smooth it out Elisp-side.

However I'd prefer loggers-allowlist (or loggers-whitelist) to clearly reflect that that only allowlisted would make it in.

(as I see it, included-loggers doesn't capture so well the "exclusive inclusion" concept).

Self-assigned.

@vemv vemv self-assigned this Jan 13, 2024
@r0man
Copy link
Collaborator

r0man commented Jan 13, 2024

Ok, let's go with allow/block (or anything similar) rather than black/white.

vemv added a commit that referenced this issue Jan 13, 2024
vemv added a commit that referenced this issue Jan 13, 2024
vemv added a commit that referenced this issue Jan 13, 2024
@vemv vemv closed this as completed in #15 Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants