Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn-refs never returns references from tests #176

Closed
vemv opened this issue Aug 6, 2023 · 1 comment · Fixed by #177
Closed

fn-refs never returns references from tests #176

vemv opened this issue Aug 6, 2023 · 1 comment · Fixed by #177

Comments

@vemv
Copy link
Member

vemv commented Aug 6, 2023

From some reason, given the var #'foo and a test #'foo-test that references foo, #'foo-test will never be included as a reference in fn-refs.

@vemv
Copy link
Member Author

vemv commented Aug 6, 2023

Easy one fortunately. If there's :test metadata, we should hit that instead:

> (-> #'orchard.eldoc-test/test-eldoc meta :test orchard.xref/fn-deps)

#{#'orchard.eldoc/eldoc
  #'clojure.core/hash-map
  #'clojure.test/*testing-contexts*
  #'clojure.core/cons
  #'clojure.core/str
  #'clojure.test/do-report
  #'orchard.info/info-java
  #'clojure.core/gensym
  #'clojure.core/not
  #'clojure.core/apply
  #'orchard.eldoc-test/test-eldoc-info
  #'clojure.core/list
  #'orchard.eldoc-test/test-eldoc-info-special-form
  #'clojure.string/trim
  #'clojure.core/push-thread-bindings
  #'clojure.core/pop-thread-bindings
  #'clojure.core/conj
  #'clojure.core/=
  #'orchard.info/info
  #'orchard.eldoc-test/test-eldoc-info-candidates}

@vemv vemv transferred this issue from clojure-emacs/cider-nrepl Aug 6, 2023
vemv added a commit that referenced this issue Aug 6, 2023
@vemv vemv closed this as completed in #177 Aug 9, 2023
vemv added a commit that referenced this issue Aug 9, 2023
vemv added a commit that referenced this issue Aug 9, 2023
### Changes

- [#176](#176): `orchard.xref`: include info for test vars.
- `orchard.xref`: avoid duplicate vars that might appear following REPL re-evaluation.
@vemv vemv mentioned this issue Aug 9, 2023
vemv added a commit that referenced this issue Aug 9, 2023
### Changes

- [#176](#176): `orchard.xref`: include info for test vars.
- `orchard.xref`: avoid duplicate vars that might appear following REPL re-evaluation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant