Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inspector] Fix inspector dropping items after nil value #28

Merged
merged 1 commit into from
Sep 8, 2018
Merged

[inspector] Fix inspector dropping items after nil value #28

merged 1 commit into from
Sep 8, 2018

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Sep 6, 2018

This is embarassing. Because of my sloppy end-of-collection checking, the inspector dropped elements after nil in collections like [1 2 nil 3 4 5].

On a side node: could you give members of clojure-emacs org the ability to push into branches (not master)? It's a little tedios to keep forks in sync.

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #28   +/-   ##
======================================
  Coverage    83.2%   83.2%           
======================================
  Files          13      13           
  Lines        1024    1024           
  Branches       40      40           
======================================
  Hits          852     852           
  Misses        132     132           
  Partials       40      40
Impacted Files Coverage Δ
src/orchard/inspect.clj 84.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d6cf6...f3bea11. Read the comment docs.

@bbatsov bbatsov merged commit cd73ca6 into clojure-emacs:master Sep 8, 2018
@bbatsov
Copy link
Member

bbatsov commented Sep 8, 2018

On a side node: could you give members of clojure-emacs org the ability to push into branches (not master)? It's a little tedios to keep forks in sync.

I'll grant you write access to all the essential repos, which is the only way I know to solve this.

Thanks for the bugfix!

@alexander-yakushev alexander-yakushev deleted the fix-nil-drop branch September 8, 2018 20:25
@alexander-yakushev
Copy link
Member Author

Thank you, Bozhidar!

bbatsov added a commit that referenced this pull request Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants