Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various inspector improvements #35

Merged
merged 7 commits into from
Nov 6, 2018
Merged

Various inspector improvements #35

merged 7 commits into from
Nov 6, 2018

Conversation

alexander-yakushev
Copy link
Member

A few useful goodies. Nothing too ground-breaking, so this might still have a chance to land into the upcoming cider-nrepl release.

  • Render everything that implements j.u.List and j.u.Map as collections –– useful when interacting with Java libraries.
  • Render inline arrays as collections – same.
  • Truncate inline long strings and other objects – this helps when the inspected object has long strings as fields/contained values, or also unknown objects with toString implementations that produce long strings. The truncation limit is quite arbitrary, but I don't think this would be too useful to customize. Also, jumping into the string still renders it fully.

@alexander-yakushev
Copy link
Member Author

Also bumped the version to snapshot because tests are failing :).

This includes strings and defaults objects (that might have custom long toString
implementations).
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #35 into master will increase coverage by 0.39%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   83.22%   83.61%   +0.39%     
==========================================
  Files          13       13              
  Lines        1031     1056      +25     
  Branches       41       40       -1     
==========================================
+ Hits          858      883      +25     
- Misses        132      133       +1     
+ Partials       41       40       -1
Impacted Files Coverage Δ
src/orchard/inspect.clj 85.23% <90.47%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fb843...d43d9af. Read the comment docs.

@bbatsov bbatsov merged commit 5911492 into master Nov 6, 2018
@bbatsov bbatsov deleted the inspector branch November 6, 2018 23:12
@bbatsov
Copy link
Member

bbatsov commented Nov 6, 2018

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants