-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various inspector improvements #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
inspector
branch
from
November 6, 2018 20:12
166fa16
to
0d50ed3
Compare
Multiple prn's into the REPL don't produce multiple newlines. Fix this by buffering the writes into the StringWriter first.
Also bumped the version to snapshot because tests are failing :). |
This includes strings and defaults objects (that might have custom long toString implementations).
alexander-yakushev
force-pushed
the
inspector
branch
2 times, most recently
from
November 6, 2018 20:28
6799531
to
d43d9af
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 83.22% 83.61% +0.39%
==========================================
Files 13 13
Lines 1031 1056 +25
Branches 41 40 -1
==========================================
+ Hits 858 883 +25
- Misses 132 133 +1
+ Partials 41 40 -1
Continue to review full report at Codecov.
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few useful goodies. Nothing too ground-breaking, so this might still have a chance to land into the upcoming cider-nrepl release.