Namespace alias support for spec-list and spec-form

[tatut]

Added support for resolving namespace aliased keywords for the current namespace.

Changes:

• spec-list will return "::some-ns-alias/some-keyword" completions in addition to the fully qualified names for specs in namespaces that have an alias in the given ns.
• spec-list will return "::some-keyword" completions in addition to the fully qualified names for specs in the given ns.
• spec-form will expand both ns aliases before resolving the spec
• added tests for ns alias functionality

I will add a separate PR for CIDER to add (cider-current-ns) for spec-list and spec-form requests in cider-client.el if this is accepted.

[bbatsov]

Sorry for the slow turnaround here! (I was away from a computer for quite a while) Can you rebase on master, so I can see the tests will pass with new CI?

The changes look good to me, but before merging this I wanted to ping @alexander-yakushev about this. It might make sense to have similar behavior for keyword in compliment for consistency's sake.

[alexander-yakushev]

@bbatsov I honestly didn't quite get what is this all about (I don't use spec much, let alone in CIDER). Could you please describe what sort of behavior would you expect from Compliment regarding this?

[bbatsov]

I think the idea is provide completion candidates with non-expanded keywords as well as those with expanded ones, when doing something ::some-keyword and :some.ns/keyword, or ::ns-alias/keyword and :real.ns/keyword. Frankly, I rarely use namespaced keywords, so I'm not 100% certain how useful this would be, but it kind of makes sense to me.

[tatut]

Yes, the point is to be able to lookup keywords with ns aliases.

I use them alot, so that I will have a require like

(:require [mything.foo-domain :as foo])

And later use keywords like ::foo/bar. This will (with the upcoming CIDER) change allow you to lookup keyword under point and it will correctly understand that it means :mything.foo-domain/bar and get the correct spec for it.

[bbatsov]

Well, apart from my small remark about spec2, I'm ready to merge this.

[tatut]

I'll touch this up this evening and make sure the tests still pass.

[alexander-yakushev]

Ah. Compliment already does that, if I remember correctly.

…

On Wed, Mar 20, 2019, 09:55 Tatu Tarvainen ***@***.***> wrote: I'll touch this up this evening and make sure the tests still pass. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcl_a5r9Thkm3Z9YVCQ_RhNHSas2egFks5vYemFgaJpZM4aTcsH> .

[tatut]

I think this should be ready for merge.

[bbatsov]

Thanks for working on this!