Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw object inspector improvements #46

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Raw object inspector improvements #46

merged 4 commits into from
Mar 29, 2019

Conversation

alexander-yakushev
Copy link
Member

  1. When inspecting objects that don't have special render handling, separate static and non-static fields. Also, sort fields by name. Looks like this:
    image

  2. Walk the class hierarchy to display not only immediate object's fields, but also fields inherited from superclasses.

@bbatsov
Copy link
Member

bbatsov commented Mar 29, 2019

Looks pretty cool! Seems there's some small issue with the formatting, the code itself looks good to me.

Also - don't forget to update the changelog.

@alexander-yakushev
Copy link
Member Author

It looks like cljfmt doesn't understand proper letfn indentation.

@alexander-yakushev
Copy link
Member Author

Should I rewrite it using regular let or are you willing to spend potentially A LOT of time to investigate? :)

@bbatsov
Copy link
Member

bbatsov commented Mar 29, 2019

Probably you can try teaching cljfmt here https://github.com/clojure-emacs/orchard/blob/master/project.clj#L58, but I'd be fine with using a regular let.

@alexander-yakushev
Copy link
Member Author

Turned out much easier than I thought.

@bbatsov bbatsov merged commit 87601fd into master Mar 29, 2019
@bbatsov bbatsov deleted the inspect branch March 29, 2019 19:17
@alexander-yakushev
Copy link
Member Author

Thanks, Bozhidar!

@bbatsov
Copy link
Member

bbatsov commented Mar 29, 2019

I've also pushed a new snapshot of cider-nrepl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants