Raw object inspector improvements #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks pretty cool! Seems there's some small issue with the formatting, the code itself looks good to me. Also - don't forget to update the changelog. |
Member
Author
|
It looks like cljfmt doesn't understand proper |
alexander-yakushev
force-pushed
the
inspect
branch
2 times, most recently
from
cf034d4 to
a5bdb4a
Compare
Member
Author
|
Should I rewrite it using regular let or are you willing to spend potentially A LOT of time to investigate? :) |
Member
|
Probably you can try teaching cljfmt here https://github.com/clojure-emacs/orchard/blob/master/project.clj#L58, but I'd be fine with using a regular |
alexander-yakushev
force-pushed
the
inspect
branch
from
a5bdb4a to
1ef86d9
Compare
Member
Author
|
Turned out much easier than I thought. |
bbatsov
approved these changes
Mar 29, 2019
Member
Author
|
Thanks, Bozhidar! |
Member
|
I've also pushed a new snapshot of cider-nrepl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting objects that don't have special render handling, separate static and non-static fields. Also, sort fields by name. Looks like this:
Walk the class hierarchy to display not only immediate object's fields, but also fields inherited from superclasses.